Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

Adapt to clippy API changes. #1759

Closed
wants to merge 1 commit into from
Closed

Conversation

hkratz
Copy link

@hkratz hkratz commented Jan 11, 2022

Against the rustup branch.

Part of the fix for rust-lang/rust#91543

@flip1995
Copy link
Member

Those changes are already included in RLS master, but not synced to the Rust repo, because for that, Racer would have to be fixed first. See #1753

@hkratz
Copy link
Author

hkratz commented Jan 11, 2022

Ah, thanks!

Is the Racer fix really needed immediately if a dummy thread_local_const_init feature gate is reintroduced? That will make rustc-ap-rustc_span build again.

@hkratz hkratz closed this Jan 11, 2022
@hkratz hkratz deleted the clippy-api-fix branch January 11, 2022 14:27
@flip1995
Copy link
Member

I think the thread_local_const_init fixes the feature gate thing. But I'm not sure if the Clippy issue can be fixed without a sync. (But let's figure this out in the Zulip thread)

@hkratz hkratz restored the clippy-api-fix branch January 11, 2022 14:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants